Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combo box filtering #145

Open
gurachan opened this issue Aug 22, 2020 · 6 comments
Open

combo box filtering #145

gurachan opened this issue Aug 22, 2020 · 6 comments

Comments

@gurachan
Copy link

ocornut/imgui#1658

like this :( kinda nice to have

@elect86
Copy link
Collaborator

elect86 commented Aug 22, 2020

We may implement the suggested option of kovewnikov..

@gurachan
Copy link
Author

gurachan commented Aug 22, 2020

yes please, that will be awesome. I will use it to search, display, and filter near online players' names entities in the game hehe. just kinda making like mtasa admin panel xD

@elect86
Copy link
Collaborator

elect86 commented Sep 17, 2020

So, I finished 1.77, merged it back into master and ported the named comboFilter

To test it, simply uncomment this and this

To simplify I opted for a much simpler and quicker startWith filter, ie only the first contiguous match will be selected, if any.

If we want to expand this, kind of like the completition on Idea where, for example, the capital letters matter, we can continue working on it together

Otherwise, if satisfied, just close it :)

@gurachan
Copy link
Author

thats available too in jdk8-snapshot one?

@elect86
Copy link
Collaborator

elect86 commented Sep 17, 2020

Now

@elect86
Copy link
Collaborator

elect86 commented Sep 19, 2020

Regarding the filtering function: we may implement some pre-defined options, such as "plain" (first which starts with the same input), "advanced" (search for the one maximizing the number of matching chars), "onCapitals" (same but priority to the capitals letters), etc etc

Just an idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants