Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and/or add various piano note flashes (note start point) #124

Closed
sreich opened this issue Jul 22, 2022 · 2 comments
Closed

Improve and/or add various piano note flashes (note start point) #124

sreich opened this issue Jul 22, 2022 · 2 comments

Comments

@sreich
Copy link
Contributor

sreich commented Jul 22, 2022

Add some additional prettier effects, or an improved one, to the piano note flash. Just from glancing without the code yet, looks texture map based, it isn't very smoothly transitioned (part of this is the velocity which is another github issue here). But most of it is the look and feel of it can be made to look more natural and less...cartoony

A good model to follow is the ones from Ember, https://www.youtube.com/watch?v=KgGZ5yX96T4 and such. atinpiano has some good effects overall to mirror those would be really awesome.

@kosua20
Copy link
Owner

kosua20 commented Aug 30, 2023

Hello, I've added the ability to customize the image flipbook used to animate the flash, along with some additional halo settings. This is available in the latest 7.1 release and should give you more flexibility in customizing the flashes appearance.

@kosua20 kosua20 closed this as completed Sep 4, 2023
@sreich
Copy link
Contributor Author

sreich commented Sep 4, 2023

Awesome! I'll check it out, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants