Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API呼び出しでの例外処理をしっかり書くと良さそうです #3

Closed
kosenda opened this issue Nov 15, 2022 · 3 comments
Closed

API呼び出しでの例外処理をしっかり書くと良さそうです #3

kosenda opened this issue Nov 15, 2022 · 3 comments
Labels
ゆめみ様からの機会点

Comments

@kosenda
Copy link
Owner

kosenda commented Nov 15, 2022

  • ともき様（Twitter：@tmk815）はじめ、株式会社ゆめみの方々からいただいた機会点
@kosenda kosenda mentioned this issue Nov 22, 2022
Merged
@kosenda
Copy link
Owner Author

kosenda commented Nov 23, 2022

修正完了

@kosenda kosenda closed this as completed Nov 23, 2022
@kosenda
Copy link
Owner Author

kosenda commented Dec 5, 2022

  • ともき様（Twitter：@tmk815）はじめ、株式会社ゆめみの方々からいただいた機会点の修正のフィードバック
    エラーの握りつぶしは無くなりましたが、何らかの方法でユーザーに視覚的に分かるようになるとさらに良いと思います

@kosenda kosenda reopened this Dec 5, 2022
@kosenda kosenda mentioned this issue Dec 8, 2022
Merged
@kosenda
Copy link
Owner Author

kosenda commented Dec 8, 2022

Interceptorでエラー用のレスポンスを作成することで、通信エラーに関してはユーザに伝えられるようになったため修正完了とする。

@kosenda kosenda closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ゆめみ様からの機会点
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kosenda