-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split korge-foundation and korge-core in submodules #2040
Comments
Do this after merging / discarding PRs to avoid conflicts. |
I won't have time for this in the shorterm. If someone wants to contribute here, PRs are welcome.
If someone wants to contribute in this split with PRs, feel free to do so. You can put a comment here to avoid other people to doing the same work. |
We have a problem with circular dependency. We might have to do a bigger refactor than just separating the packages into modules |
The math and the logger modules use the korlibs-datastructure, therefor we have circular dependency of gradle tasks and this problem is not solvable without gradle changes |
@holloszaboakos it should be fine: Just add
|
That doesn't solve circular dependency problem (korlibs-datastructure also needs dependency for foundation). However as we already discussed on discord, we can duplicate code and make that internal. |
Like the old libs, but for package name. Keeping
korge-foundation
andkorge-core
as a module without code linking to each module individually.korge-time
korge-crypto
korge-datastructure
So everything works as before but people can get the libraries segmented to what they need.
The text was updated successfully, but these errors were encountered: