Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies cause unwanted addition of Android permissions #2003

Closed
mstarostik opened this issue Sep 14, 2023 · 1 comment · Fixed by #2004
Closed

dependencies cause unwanted addition of Android permissions #2003

mstarostik opened this issue Sep 14, 2023 · 1 comment · Fixed by #2004
Labels

Comments

@mstarostik
Copy link

Spotted on all korGE projects I've tried so far:

The dependencies managed by kproject, internal, external, or just ./deps result in the addition of Android permissions READ_EXTERNAL_STORAGE, WRITE_EXTERNAL_STORAGE, and most noteworthy READ_PHONE_STATE
This is caused by the dependencies' build.gradle files not specifying any Android SDK versions and so, there will be intermediate AndroidManifest.xml files generated for the deps, that contain

    <uses-sdk
        android:minSdkVersion="1"
        android:targetSdkVersion="1" />

While the final manifest actually specifies sensible SDK versions, this intermediate version 1 leads to:

uses-permission#android.permission.WRITE_EXTERNAL_STORAGE
IMPLIED from [...]/build/AndroidManifest.xml:2:1-32:12 reason: hello.deps has a targetSdkVersion < 4
uses-permission#android.permission.READ_PHONE_STATE
IMPLIED from [...]/build/AndroidManifest.xml:2:1-32:12 reason: hello.deps has a targetSdkVersion < 4
uses-permission#android.permission.READ_EXTERNAL_STORAGE
IMPLIED from [...]/build/AndroidManifest.xml:2:1-32:12 reason: hello.deps requested WRITE_EXTERNAL_STORAGE

Especially READ_PHONE_STATE is not something I want the app to request.

@soywiz soywiz transferred this issue from korlibs/kproject Nov 3, 2023
@soywiz
Copy link
Member

soywiz commented Nov 3, 2023

Moved, since now the kproject stuff is integrated in the korge repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
2 participants