Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect CSS syntax/values in bootstrapfx.css? #20

Open
juananpe opened this issue Jan 21, 2023 · 0 comments
Open

Incorrect CSS syntax/values in bootstrapfx.css? #20

juananpe opened this issue Jan 21, 2023 · 0 comments

Comments

@juananpe
Copy link

Trying to solve this problem (#14 (comment)) I resorted to plan B: extract the bootstrapfx.css from BootstrapFX's JAR file, copy it in the resources/ folder and use it. This plan B (though is not the correct way) worked as a charm... anyway, in the process I spent some time analyzing the CSS file and I think that I found some strange errors: (I'm not a CSS expert, so I'm not sure if those are really errors, could you please double check my asssumptions?):

image

For example, in line 168 there is a call to the darken() function:

a.bg-warning:focused {
    --fxbackground-color: darken($color, 10%); }

but reading the JavaFX CSS specification:
https://docs.oracle.com/javafx/2/api/javafx/scene/doc-files/cssref.html
I can't find any darken function (the only reference to darken is as a possible value of -fx-blend-mode)

In line 214 we have this:

.btn:pressed, .btn.pressed {
    -fx-effect: innershadow(gaussian, rgba(0, 0, 0, 0.125), 5px, 0, 0, 3px); }

image

But according to the specification:
https://docs.oracle.com/javafx/2/api/javafx/scene/doc-files/cssref.html#:~:text=The%20shadow%20Color.-,%3Cnumber%3E%20the%20radius%20of%20the%20shadow%20blur%20kernel.%20in%20the%20range%20%5B0.0%20...%20127.0%5D%2C%20typical%20value%2010.,-%3Cnumber%3E%0A%20%20%20%20%20%20The%20choke
the radius should be a number in the range [0.0 ... 127.0] (without the px unit name)

Finally IntelliJ's editor is also barking at this:
image

Again, according to the specification, could it be because the selector name should be selected insted of checked?
https://docs.oracle.com/javafx/2/api/javafx/scene/doc-files/cssref.html#checkmenuitem

Thank you for reading till the end! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant