Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

OpenStack virtio-scsi device path can contain full cinder uuid instead of shorten one #357

Open
goberle opened this issue Nov 12, 2020 · 3 comments

Comments

@goberle
Copy link
Contributor

goberle commented Nov 12, 2020

Same issue than : kubernetes/cloud-provider-openstack#852

root@master-nova-1-1-dnum-k8s-dev-k8s-local:/mnt# ls /dev/disk/by-id/
scsi-0QEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b
scsi-SQEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b
scsi-0QEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b-part1
scsi-SQEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b-part1
scsi-0QEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b-part14
scsi-SQEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b-part14
scsi-0QEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b-part15
scsi-SQEMU_QEMU_HARDDISK_4f1fb573-0570-4c65-96ca-0f33b550324b-part15
scsi-0QEMU_QEMU_HARDDISK_4f70c734-cc89-44cd-89fa-6858e31da7aa
scsi-SQEMU_QEMU_HARDDISK_4f70c734-cc89-44cd-89fa-6858e31da7aa
scsi-0QEMU_QEMU_HARDDISK_b38e8c0d-1998-425c-ad5d-749f5cfb98ed
scsi-SQEMU_QEMU_HARDDISK_b38e8c0d-1998-425c-ad5d-749f5cfb98ed

and it doesn't match any of patterns which plugin looks for:

candidateDeviceNodes := []string{
	// KVM
	fmt.Sprintf("virtio-%s", volumeID[:20]),
	// KVM virtio-scsi
	fmt.Sprintf("scsi-0QEMU_QEMU_HARDDISK_%s", volumeID[:20]),
	// ESXi
	fmt.Sprintf("wwn-0x%s", strings.Replace(volumeID, "-", "", -1)),
}
@goberle
Copy link
Contributor Author

goberle commented Nov 13, 2020

Pull request : #358

@hakman
Copy link
Contributor

hakman commented Nov 14, 2020

CC @olemarkus @zetaab

@zetaab
Copy link
Contributor

zetaab commented Feb 3, 2021

PR is merged, so this should be closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants