-
-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
layers vs. groups performance #1713
Comments
Hello. Are you sure lighthouse is measuring that kind of performance and memory usage? I didn't use lighthouse for a long time. But from what I remember, it is mainly focused on initial loading of the page. |
Thx for the fast reply. Yes, you are right, we measured initial loading of the map editor. There memory even slightly decreased when we used layers instead of groups. Can you give us some insight which kind of performance you noticed degraded? When and how was it measured? The documentation we found is not very specific about it. |
You can play with this demo: https://codesandbox.io/p/sandbox/performance-test-r56sn8?file=%2Findex.html%3A19%2C1 For me, the performance when |
Thank you! ❤️
How did you measure the performance? I don't see a visual difference (circles care changing like crazy regardless of Is the warning with 6 layers really justified? Did you see/measure the negative effect you warn about with the 50 layers in this demo? |
Ahh, with 100 layers I shortly noticed a difference, you are right, Then I tried to manually count with 200 layers but in both cases I ended up with counting 30 frames in 10 seconds. But this high number of layers wouldn't matter for my application anyway. 😑 |
What about memory usage? |
Hi, I'm another PermaplanT (the project maintained by @markus2330) contributor and just had a look at your demo. Key observations:
I did not look at memory usage in detail (yet), but there did not seem to be any significant difference. |
On https://konvajs.org/docs/performance/All_Performance_Tips.html#Layers it says:
We tried to reproduce and couldn't find any performance or memory overhead compared with groups using Lighthouse for up to 20 groups/layers . Is above information and the warning up to date? To which platforms/browsers does this information refer to?
Looking forward to some insight in this topic and maybe improvements in the documentation (hence I created an issue).
The text was updated successfully, but these errors were encountered: