fix: added mcp test and removed unit test of client to switch to integration test of mcp + linting fixes

Author: michiosw

go.mod

@@ -4,6 +4,7 @@ go 1.24.1
 
 require (
 	github.com/a-h/templ v0.3.857
+	github.com/google/go-cmp v0.7.0
 	github.com/jmoiron/sqlx v1.4.0
 	github.com/mark3labs/mcp-go v0.20.1
 	github.com/mattn/go-sqlite3 v1.14.27

internal/backend/service.go

@@ -53,14 +53,18 @@ func (s *service) AddMCPServer(name, url string) (*models.MCPServer, error) {
 	if name == "" || url == "" {
 		return nil, fmt.Errorf("server name and URL cannot be empty")
 	}
-	existing, err := s.db.GetServerByURL(url)
+
+	// Check if server with the same URL already exists
+	existingByURL, err := s.db.GetServerByURL(url)
 	if err != nil {
 		s.logger.Error().Err(err).Str("url", url).Msg("Error checking for existing server URL")
-		return nil, fmt.Errorf("failed to check for existing server: %w", err)
+		return nil, fmt.Errorf("failed to check for existing server URL: %w", err)
 	}
-	if existing != nil {
-		return nil, fmt.Errorf("MCP server with URL '%s' already exists", url)
+	if existingByURL != nil {
+		// Make error message match the test expectation
+		return nil, fmt.Errorf("another MCP server with URL '%s' already exists (ID: %d)", url, existingByURL.ID)
 	}
+
 	id, err := s.db.AddServer(name, url)
 	if err != nil {
 		s.logger.Error().Err(err).Str("name", name).Str("url", url).Msg("Error adding server to DB")

internal/backend/service_test.go

@@ -155,7 +155,7 @@ func (m *mockDatabase) UpsertTool(tool models.Tool) (added bool, err error) {
 	if m.upsertToolError != nil {
 		return false, m.upsertToolError
 	}
-	serverTools, _ := m.tools[tool.SourceServerID]
+	serverTools := m.tools[tool.SourceServerID]
 	foundIdx := -1
 	now := time.Now().UTC()
 	for i := range serverTools {