Skip to content

fix: add --no-color to rules#1428

Merged
openshift-merge-bot[bot] merged 1 commit into
konflux-ci:mainfrom
psturc:add-no-color-to-rules
Oct 14, 2024
Merged

fix: add --no-color to rules#1428
openshift-merge-bot[bot] merged 1 commit into
konflux-ci:mainfrom
psturc:add-no-color-to-rules

Conversation

@psturc

@psturc psturc commented Oct 11, 2024

Copy link
Copy Markdown
Member

Description

we still see these escaped characters in the e2e tests output:

Will run �[1m6�[0m of �[1m327�[0m specs
Running in parallel across �[1m20�[0m processes
�[38;5;14mS�[0m�[38;5;14mS�[0m�[38;5;14mS�[0m�[38;5;14mS�[0m�[38;5;14mS�[0m�[38;5;14mS�[0m�[38;5;14mS�[0m�[38;5;14mS�[0m�[38;5;14mS�[0m�[38;5;14mS�[0m�[38;5;14mS�[0m�[38;5;14mS�[0m�[38;5;14mS�[0m�[38;5;14mS�[0m�[38;5;14mS�[0m�[38;5;14mS�[0m�[38;5;14mS�[0m
�[38;5;243m------------------------------�[0m
�[38;5;11mP [PENDING]�[0m

setting the ReporterConfig's NoColor field to true should fix this

Issue ticket number and link

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

in CI 🤷

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@dheerajodha dheerajodha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it works now:

[e2e-test] Will run 254 of 327 specs
[e2e-test] Running in parallel across 20 processes
[e2e-test] ------------------------------
[e2e-test] P [PENDING]

Thanks for the fix

@openshift-ci

openshift-ci Bot commented Oct 14, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dheerajodha, kasemAlem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dheerajodha,kasemAlem]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dheerajodha

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Oct 14, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit 30fcc34 into konflux-ci:main Oct 14, 2024
@psturc psturc deleted the add-no-color-to-rules branch October 14, 2024 11:54
tnevrlka pushed a commit to tnevrlka/e2e-tests that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants