Skip to content

fix(KONFLUX-4965): add prometheus metrics to max-concurrency collector#1423

Merged
openshift-merge-bot[bot] merged 1 commit into
konflux-ci:mainfrom
rh-rahulshetty:update_collector_promql
Oct 15, 2024
Merged

fix(KONFLUX-4965): add prometheus metrics to max-concurrency collector#1423
openshift-merge-bot[bot] merged 1 commit into
konflux-ci:mainfrom
rh-rahulshetty:update_collector_promql

Conversation

@rh-rahulshetty

Copy link
Copy Markdown
Collaborator

Description

The PR adds additional PromQL to max-concurrency metric collector config.

Issue ticket number and link

https://issues.redhat.com/browse/KONFLUX-4965

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Successfully tested the changes by running max-concurrency builds on Hive cluster.

export THRESHOLD=1500 MAX_THREADS=200 MAX_CONCURRENCY_STEPS=1 COMPONENT_REPO=https://github.com/rh-perf-test-org/devfile-sample PIPELINE_REQUEST_CONFIGURE_PAC=true
./tests/load-tests/ci-scripts/max-concurrency/load-test.sh
./tests/load-tests/ci-scripts/max-concurrency/collect-results.sh

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@rh-rahulshetty

Copy link
Copy Markdown
Collaborator Author

/test images

@jhutar jhutar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Oct 15, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhutar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 070438b into konflux-ci:main Oct 15, 2024
tnevrlka pushed a commit to tnevrlka/e2e-tests that referenced this pull request Oct 17, 2024
konflux-ci#1423)

KONFLUX-4965 add prometheus metrics to max-concurrency collector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants