feat: verify REPORTS result from clair-scan Task

[lcarva]

Description

Add validation for the REPORTS result emitted by the clair-scan Task.

Issue ticket number and link

https://issues.redhat.com/browse/EC-839

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
• I have updated labels (if needed)

[kasemAlem]

@lcarva ,
it failed on build-e2e test see in below :

�[38;5;9m• [FAILED] [1.660 seconds]�[0m
[e2e-test] �[0m[build-service-suite Build templates E2E test] �[38;5;243mHACBS pipelines �[38;5;9m�[1m[It] should validate tekton taskrun test results for component with Git source URL https://github.com/redhat-appstudio-qe/devfile-sample-python-basic and Pipeline docker-build�[0m �[38;5;204m[build, build-templates, HACBS, pipeline, build-templates-e2e]�[0m
[e2e-test] �[38;5;243m/tmp/tmp.HvWIRD4Cpp/tests/build/build_templates.go:496�[0m
[e2e-test] 
[e2e-test]   �[38;5;9m[FAILED] Expected success, but got an error:
[e2e-test]       <*errors.errorString | 0xc000f67c30>: 
[e2e-test]       expected result name "REPORTS" not found in Task "clair-scan" result
[e2e-test]       {
[e2e-test]           s: "expected result name \"REPORTS\" not found in Task \"clair-scan\" result",
[e2e-test]       }�[0m
[e2e-test]   �[38;5;9mIn �[1m[It]�[0m�[38;5;9m at: �[1m/tmp/tmp.HvWIRD4Cpp/tests/build/build_templates.go:499�[0m �[38;5;243m@ 10/07/24 21:43:50.393�[0m

[lcarva]

Thanks, @kasemAlem!

For some reason, the build pipeline is using an older version of the v0.2/clair-scan Task which does not include the result. I'll dig more into it.

[lcarva]

I believe we need this merged first: redhat-appstudio/infra-deployments#4664

[lcarva]

/retest

[kasemAlem]

/retest

[kasemAlem]

redhat-appstudio/infra-deployments#4664

I've retested after ensuring that the PR was merged already , still failed on known e2e-tests issue ,

[kasemAlem]

/retest

[kasemAlem]

/retest

[kasemAlem]

@lcarva , now it fails on build templates test , tekton validation , see in here

 Errors: [
                  {
                      Code: "BLOB_UNKNOWN",
                      Message: "blob unknown to registry",
                      Detail: <map[string]interface {} | len:0>{},
                  },

[lcarva]

@kasemAlem, thanks! It looks like a bug on the my test. I'll update.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasemAlem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kasemAlem]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lcarva]

cannot fetch report from ref quay.io/redhat-appstudio-qe/konflux-naor-tenant/konflux-demo-component-lain:6cec6ff6771333ae1a4299b8851cbb888fa98e0a@sha256:d98baab755aca2e49c655aa637a564d58fb35c3c447ddddca2b3f657529d0407: content size 89379276 exceeds push size limit 4194304: size exceeds limit

Hmm not sure where all that data is coming from. The report is only 1253954. I'll keep digging.

[lcarva]

Updated the PullArtifacts function to not follow the subjects. Without this, the binary image itself also gets pulled which is not the desired behavior.

[lcarva]

/retest

[kasemAlem]

failed on running e2e-test task , will retest

[kasemAlem]

/retest

[kasemAlem]

/retest

[kasemAlem]

rosa & quality dashboard known issue
/retest

[lcarva]

/retest

[kasemAlem]

@lcarva , it failed on build e2e-test different error:

�[38;5;9m• [FAILED] [3.018 seconds]�[0m
[e2e-test] �[0m[build-service-suite Build templates E2E test] �[38;5;243mHACBS pipelines �[38;5;9m�[1m[It] should push Dockerfile to registry�[0m �[38;5;204m[build, build-templates, HACBS, pipeline, build-templates-e2e]�[0m
[e2e-test] �[38;5;243m/tmp/tmp.xnVXzwFKEA/tests/build/build_templates.go:364�[0m
[e2e-test] 
[e2e-test]   �[38;5;9m[FAILED] Expected success, but got an error:
[e2e-test]       <*fmt.wrapError | 0xc001aae080>: 
[e2e-test]       failed to resolve : invalid reference
[e2e-test]       {
[e2e-test]           msg: "failed to resolve : invalid reference",
[e2e-test]           err: <*errors.errorString | 0x5037ec0>{
[e2e-test]               s: "invalid reference",

[kasemAlem]

/lgtm