fix: use finalizer lock in EC build-definitions#1415
Merged
Conversation
The EC test in build-definitions was failing because the PipelineRun was garbage collected mid-test, so the logs that are asserted were not available. This uses a finalizer lock on the PipelineRun to make sure it is still present while the logs are asserted in the test scenario.
1 task
lcarva
approved these changes
Oct 3, 2024
simonbaird
approved these changes
Oct 3, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcarva, psturc, simonbaird The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Oct 3, 2024
This was referenced Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The EC test in build-definitions was failing because the PipelineRun was garbage collected mid-test, so the logs that are asserted were not available.
This uses a finalizer lock on the PipelineRun to make sure it is still present while the logs are asserted in the test scenario.
Issue ticket number and link
Type of change
How Has This Been Tested?
Ran with this version in build-definitions on konflux-ci/build-definitions#1460
Checklist: