Skip to content

feat(KONFKUX-4006): Add mage engine rules for build-service repo#1414

Merged
openshift-merge-bot[bot] merged 2 commits into
konflux-ci:mainfrom
flacatus:build_srv
Oct 3, 2024
Merged

feat(KONFKUX-4006): Add mage engine rules for build-service repo#1414
openshift-merge-bot[bot] merged 2 commits into
konflux-ci:mainfrom
flacatus:build_srv

Conversation

@flacatus

@flacatus flacatus commented Oct 2, 2024

Copy link
Copy Markdown
Member

Description

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci openshift-ci Bot requested review from Dannyb48 and jinqi7 October 2, 2024 09:07
Comment thread magefiles/rulesengine/repos/build_service.go Outdated
@flacatus

flacatus commented Oct 2, 2024

Copy link
Copy Markdown
Member Author

@psturc fixed

@psturc psturc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Oct 2, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psturc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Oct 2, 2024
@psturc

psturc commented Oct 2, 2024

Copy link
Copy Markdown
Member
step-e2e-test

Unable to connect to the server: dial tcp: lookup api.kx-7fa776d8d4.ycdh.p3.openshiftapps.com on 172.30.0.10:53: no such host

strange, giving the fact that the oc login is tested in the provision-rosa taskrun, which runs before konflux-e2e-tests taskrun

/retest

@psturc

psturc commented Oct 3, 2024

Copy link
Copy Markdown
Member

/retest

@psturc

psturc commented Oct 3, 2024

Copy link
Copy Markdown
Member

again, the same failure

[e2e-test] Unable to connect to the server: dial tcp: lookup api.kx-ec8e86401e.k51c.p3.openshiftapps.com on 172.30.0.10:53: no such host

it might be worth looking into improving the cluster health check in provision-rosa task

@flacatus

flacatus commented Oct 3, 2024

Copy link
Copy Markdown
Member Author

/retest

2 similar comments
@flacatus

flacatus commented Oct 3, 2024

Copy link
Copy Markdown
Member Author

/retest

@flacatus

flacatus commented Oct 3, 2024

Copy link
Copy Markdown
Member Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants