From 998594d746bb19deae271d16099cd83c35f62942 Mon Sep 17 00:00:00 2001 From: Jing Qi Date: Mon, 19 Aug 2024 20:50:09 +0800 Subject: [PATCH 1/2] fix: update_repo in release const.go Signed-off-by: Jing Qi --- tests/release/const.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/release/const.go b/tests/release/const.go index ef49274cf7..3b4d687cd5 100644 --- a/tests/release/const.go +++ b/tests/release/const.go @@ -34,9 +34,9 @@ const ( // Pipelines constants ComponentName string = "dc-metro-map" - GitSourceComponentUrl string = "https://github.com/scoheb/dc-metro-map" + GitSourceComponentUrl string = "https://github.com/redhat-appstudio-qe/dc-metro-map-release" AdditionalComponentName string = "simple-python" - AdditionalGitSourceComponentUrl string = "https://github.com/devfile-samples/devfile-sample-python-basic" + AdditionalGitSourceComponentUrl string = "https://github.com/redhat-appstudio-qe/devfile-sample-python-basic-test2" ReleasedImagePushRepo string = "quay.io/redhat-appstudio-qe/dcmetromap" AdditionalReleasedImagePushRepo string = "quay.io/redhat-appstudio-qe/simplepython" PyxisStageImagesApiEndpoint string = "https://pyxis.preprod.api.redhat.com/v1/images/id/" From 6f26f1d9c5ccda9a49a538657e21fab107d92bf1 Mon Sep 17 00:00:00 2001 From: Jing Qi Date: Fri, 27 Sep 2024 18:41:24 +0800 Subject: [PATCH 2/2] fix: checking if the terminated reason contains failed Signed-off-by: Jing Qi Since the terminated reason can be "TaskRunImagePullFailed", add the condition to check if terminated reason contains "Failed" --- pkg/utils/tekton/pipelineruns.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/utils/tekton/pipelineruns.go b/pkg/utils/tekton/pipelineruns.go index d71c7b30ff..23f29f614a 100644 --- a/pkg/utils/tekton/pipelineruns.go +++ b/pkg/utils/tekton/pipelineruns.go @@ -5,6 +5,7 @@ import ( "encoding/json" "fmt" "strconv" + "strings" "k8s.io/client-go/kubernetes" "knative.dev/pkg/apis" @@ -239,7 +240,7 @@ func GetFailedPipelineRunDetails(c crclient.Client, pipelineRun *pipeline.Pipeli d.FailedTaskRunName = taskRun.Name d.PodName = taskRun.Status.PodName for _, s := range taskRun.Status.TaskRunStatusFields.Steps { - if s.Terminated.Reason == "Error" { + if s.Terminated.Reason == "Error" || strings.Contains(s.Terminated.Reason, "Failed"){ d.FailedContainerName = s.Container return d, nil }