buildah: don't modify Dockerfile in place#1462
Merged
chmeliik merged 2 commits intoSep 27, 2024
Merged
Conversation
Contributor
Author
|
/retest |
Contributor
Author
|
/test |
Contributor
Author
|
/retest |
chmeliik
force-pushed
the
dont-leave-dockerfile-modified
branch
from
d73bd22 to
fb6d731
Compare
Contributor
Author
|
/test |
chmeliik
force-pushed
the
dont-leave-dockerfile-modified
branch
from
fb6d731 to
ab263b3
Compare
Contributor
Author
|
/test |
chmeliik
force-pushed
the
dont-leave-dockerfile-modified
branch
from
ab263b3 to
e054269
Compare
Contributor
Author
|
/test |
Contributor
Author
|
/retest |
chmeliik
force-pushed
the
dont-leave-dockerfile-modified
branch
from
e054269 to
0eba467
Compare
Contributor
Author
|
/test |
Contributor
Author
|
Without the fix, the e2e-tests fail as expected (though with a message not exactly readable to humans)
Now let's re-apply the fix and see 🤞 |
chmeliik
force-pushed
the
dont-leave-dockerfile-modified
branch
from
0eba467 to
d1645fc
Compare
Contributor
Author
|
/test |
9 tasks
Contributor
Author
|
It's working 🎉 |
chmeliik
force-pushed
the
dont-leave-dockerfile-modified
branch
from
d1645fc to
ec7be1f
Compare
Contributor
Author
|
/test |
eskultety
reviewed
Sep 27, 2024
STONEBLD-2795 Instead, make a copy outside the repo and modify the copy. This is to avoid dirtying the repo. For example, when combined with the push-dockerfile task, the pipeline will now push the original dockerfile instead of pushing the modified one. Signed-off-by: Adam Cmiel <acmiel@redhat.com>
The '... -t $IMAGE' line changed, making checkton report the violations on this line: - $IMAGE needs quotes (valid) - $IMAGE is a potential misspelling of $image (not valid, IMAGE is defined externally but checkton doesn't know that) Signed-off-by: Adam Cmiel <acmiel@redhat.com>
chmeliik
force-pushed
the
dont-leave-dockerfile-modified
branch
from
ec7be1f to
6242a21
Compare
tkdchen
approved these changes
Sep 27, 2024
mkosiarc
approved these changes
Sep 27, 2024
eskultety
approved these changes
Sep 27, 2024
mmorhun
approved these changes
Sep 27, 2024
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STONEBLD-2795
Instead, make a copy outside the repo and modify the copy. This is to
avoid dirtying the repo.
For example, when combined with the push-dockerfile task, the pipeline
will now push the original dockerfile instead of pushing the modified
one.