Bbox #421
Merged
Bbox #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Holger Bruch <[email protected]> # Conflicts: # src/main/java/de/komoot/photon/query/PhotonRequestFactory.java
Signed-off-by: Holger Bruch <[email protected]> # Conflicts: # src/main/java/de/komoot/photon/query/PhotonRequestFactory.java
The previous test request was not consistent with the spec given in the documentation. I just swapped the latitude values.
lonvia
reviewed
Jun 14, 2019
| if (minLat > 90.0 || minLat < -90.00 || maxLat > 90.0 || maxLat < -90.00) { | ||
| throw new BadRequestException(400, INVALID_BBOX_ERROR_MESSAGE); | ||
| } | ||
| bbox = new Envelope(minLon, minLat, maxLon, maxLat); |
There was a problem hiding this comment.
There is a double error in here that happens to cancel itself out. bbox above is parsed as (minLon, maxLon, minLat, maxLat) while it should be (minLon, minLat, MaxLon, MaxLat). In the constructor for Envelope the exact reverse is true.
There was a problem hiding this comment.
Changed code according to the documentation
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of #364 by @hbruch:
I basically just rebased origin/master as all previous remarks had already been fixed by hbruch