Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension of: Add some tests of the API #420

Merged
merged 8 commits into from
Jun 14, 2019
Merged

Extension of: Add some tests of the API #420

merged 8 commits into from
Jun 14, 2019

Conversation

karussell
Copy link
Collaborator

@karussell karussell commented Jun 14, 2019 •
edited
Loading

See #400 from @simonpoole - thanks :) !

@karussell karussell mentioned this pull request Jun 14, 2019
Closed
@karussell karussell requested a review from lonvia June 14, 2019 14:32
@lonvia lonvia merged commit 00b424b into master Jun 14, 2019
@karussell
Copy link
Collaborator Author

It is important to note that to run these tests from IntelliJ the following tweak has to be done to avoid "jar hell" exception:

  • Go to: Help -> Edit Custom Properties
  • Put idea.no.launcher=true on a new line
  • restart IntelliJ

See https://github.com/elastic/elasticsearch/blob/master/CONTRIBUTING.md#configuring-ides-and-running-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonvia lonvia lonvia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karussell @lonvia @simonpoole