Remove diacritics from words #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix #326. https://www.elastic.co/guide/en/elasticsearch/guide/current/asciifolding-token-filter.html explains the Elasticsearch behaviour.
|
That took a couple of trials but here we go: master: http://photon.staging.lonvia.de/master.html Both imported from the same Nominatim world data. At least the Ile d'Oleron example seems to do okay. Now I only need to find out how to run the geocoder tests. |
|
Superb - thanks for testing that, looks like it does what it should! |
|
geocoding tester reports 26 new failures and 149 new passing. Full log at http://photon.staging.lonvia.de/330.log There are one or two odd ones like 'La Nouvelle Ève' where the exact match does not turn up anymore but altogether an improvement. |
lonvia
approved these changes
May 18, 2018
|
Thanks @systemed ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #326. https://www.elastic.co/guide/en/elasticsearch/guide/current/asciifolding-token-filter.html explains the Elasticsearch behaviour.