You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Good idea, the point is nobody else than us is using this endpoint, we can also rename it as we want. The point is that the public api should be served by the java implementation, because of its new features that the python counterpart does not have.
3269a30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe let it active when in DEBUG?
3269a30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, the point is nobody else than us is using this endpoint, we can also rename it as we want. The point is that the public api should be served by the java implementation, because of its new features that the python counterpart does not have.
3269a30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but it's still precious (for me at least) for quick prototyping :)
Renaming it sounds good.
3269a30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, we don't like to recompile for development iterations ;-)