This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Set maximum version for jinja requirement #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, the latest version will always be fetched. However, as of version 3.0.0, python 2.7 support was dropped, meaning there is a BC issue since pipelines still using python 2.7 are breaking. Unless this is an deliberate decision, a max version should be set on the jinja requirement and future changelogs should state that python 2.7/3.5 support is dropped if it were to be removed again
removed references to these python versions since support for these is dropped in jinja 2.11.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a max version set for jinja, it now gets jinja 3.0.0, which dropped support for python 2.7 and 3.5, causing a BC break on any tag up until now using these versions.
Adding this version here allows the latest version to still support these, but also means it should be considered to have future versions of j2cli not support these versions of python if it is not necessary anymore by choice..
Fixes #53