Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimated savings are misleading with barters for items that cannot be bought anywhere #137

Open
Iodred opened this issue Feb 1, 2022 · 1 comment

Comments

@Iodred
Copy link

Iodred commented Feb 1, 2022

Inspecting items that cannot be bought directly from the Flea and any trader, when they have a barter, the Estimated savings are the same as the InstaProfit value.

Examples are the MMAC rig at Ragman and the REAP-IR scope

This is misleading because technically there's no savings to be made cuz you can't technically buy them anywhere.
My proposal is to just show 'N/A' or 0 with a tooltip that says 'This item cannot be bought for money' or something along those lines. And for the Barter profit table for ranking you would then just treat them as a zero.

@kokarn
Copy link
Owner

kokarn commented Feb 1, 2022

That's a good point, will implement something along these lines 👍
Have been thinking a while about how to treat all these things with "no value" etc, and this sounds like a nice solution. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants