Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imu_cursor is not used in loose_initial_state_estimation.cpp #116

Open
KOKIAOKI opened this issue Nov 21, 2024 · 2 comments
Open

imu_cursor is not used in loose_initial_state_estimation.cpp #116

KOKIAOKI opened this issue Nov 21, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@KOKIAOKI
Copy link

KOKIAOKI commented Nov 21, 2024

Describe the bug
Hello! koide3! Thank you for your support always.

I wonder why imu_cursor is not used for imu_data in this line.

const Eigen::Vector3d acc_local = imu_data[i].middleRows<3>(1);

To Reproduce
Is the following correct?

const Eigen::Vector3d acc_local = imu_data[imu_cursor].middleRows<3>(1);

Then, run to check

ros2 run glim_ros glim_rosbag [bag file]

Expected behavior
I think this will correct the estimation of the direction of gravitational acceleration while moving.

Screenshots
I haven't seen any differences in the test data, but I'll update if I find any changes in other data.

Environment (please complete the following information):

  • CPU/GPU: Corei7-13700H (laptop)
  • OS: ubuntu22
  • ROS: ROS2 humble
  • CUDA: CUDA12.2
  • Build with CUDA: ON

Additional context

@KOKIAOKI KOKIAOKI added the bug Something isn't working label Nov 21, 2024
@KOKIAOKI KOKIAOKI changed the title imu_sursor is not used in loose_initial_state_estimation.cpp imu_cursor is not used in loose_initial_state_estimation.cpp Nov 21, 2024
@koide3
Copy link
Owner

koide3 commented Nov 24, 2024

Thanks for reporting the issue. Yes, it should use imu_cursor instead of i. I'll fix it soon. Fortunately, this bug should only have a small impact because sum_acc_odom is used for only rough initial estimation of the gravity direction.

@koide3 koide3 pinned this issue Nov 24, 2024
@koide3
Copy link
Owner

koide3 commented Nov 26, 2024

I just merged a PR to fix this issue #119. Thanks again for your report.

@koide3 koide3 unpinned this issue Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants