-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KohanaPHP for PHP7 #31
Comments
I just tried to add PHP 7 to Travis and it did not build because of the old version of markdown class used in userguide. Having in mind our limited resources, I am not sure if it is a good idea to support PHP 7 for Kohana v3.3. However, I am 👍 for supporting PHP 7 for the hopeful newer v3.4 release. I wonder what others would think. |
I agree, PHP7 support in 3.4 would be worth having, it's likely too much effort for 3.3 unless someone wants to volunteer to do it. |
I agree to put it into 3.4. I can voluntee with my company to work on it (we build web apps based on kohanaphp), but I have problem to pull git repository (I can only clone and work standalone without pushing changes to github). |
Ok, I forked kohana core, but please tell which core branch i should start developing 3.4 / 3.5 ? |
Thanks for volunteering! You'll need to do it one module at a time. I suggest starting with kohana/core and kohana/unittest because the other modules depend on them and won't build till they're working. Fork each project and start a feat/php7-support branch or something like that based on 3.4/develop. Probably easiest to start with a single commit adding php7 to the .travis.yml, then start a pull request (back to 3.4/develop) and see if it passes. If not then you can start fixing whatever's broken and/or discuss issues with us on the relevant PR. Some of the modules may "just work". Once all the modules are green then kohana/kohana should be easy. Does that make sense? |
I think, I'll need to create new branch, couse in PHP 7 are to many changes, so changes already made in 3.4 are for php 5.5/5.6 so those also will need to be rewrite in some parts. |
Dariusz, yes, you need to start a new feature branch (you should always do that for any new work) but it must start from and merge back to our 3.4/develop. We cannot accept your contribution if it doesn't. You shouldn't need to redo many of the changes for PHP5.5 that have already been done, since those things haven't changed again for PHP7 AFAIK? |
hello. i am implement web pages and title solutions in kohana. |
Will be kohanaphp developed for PHP 7?
The text was updated successfully, but these errors were encountered: