Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KohanaPHP for PHP7 #31

Open
MODUS-IT-DEPRECATED opened this issue Aug 18, 2015 · 8 comments
Open

KohanaPHP for PHP7 #31

MODUS-IT-DEPRECATED opened this issue Aug 18, 2015 · 8 comments

Comments

@MODUS-IT-DEPRECATED
Copy link

Will be kohanaphp developed for PHP 7?

@enov
Copy link
Contributor

enov commented Aug 18, 2015

I just tried to add PHP 7 to Travis and it did not build because of the old version of markdown class used in userguide.

Having in mind our limited resources, I am not sure if it is a good idea to support PHP 7 for Kohana v3.3.

However, I am 👍 for supporting PHP 7 for the hopeful newer v3.4 release.

I wonder what others would think.

@acoulton
Copy link
Member

I agree, PHP7 support in 3.4 would be worth having, it's likely too much effort for 3.3 unless someone wants to volunteer to do it.

@MODUS-IT-DEPRECATED
Copy link
Author

I agree to put it into 3.4. I can voluntee with my company to work on it (we build web apps based on kohanaphp), but I have problem to pull git repository (I can only clone and work standalone without pushing changes to github).
Mayby it would be a good idea to invite to cooperate at kohana some academic groups?

@MODUS-IT-DEPRECATED
Copy link
Author

Ok, I forked kohana core, but please tell which core branch i should start developing 3.4 / 3.5 ?

@acoulton
Copy link
Member

Thanks for volunteering! You'll need to do it one module at a time. I suggest starting with kohana/core and kohana/unittest because the other modules depend on them and won't build till they're working.

Fork each project and start a feat/php7-support branch or something like that based on 3.4/develop.

Probably easiest to start with a single commit adding php7 to the .travis.yml, then start a pull request (back to 3.4/develop) and see if it passes. If not then you can start fixing whatever's broken and/or discuss issues with us on the relevant PR. Some of the modules may "just work".

Once all the modules are green then kohana/kohana should be easy.

Does that make sense?

@MODUS-IT-DEPRECATED
Copy link
Author

I think, I'll need to create new branch, couse in PHP 7 are to many changes, so changes already made in 3.4 are for php 5.5/5.6 so those also will need to be rewrite in some parts.

@acoulton
Copy link
Member

Dariusz, yes, you need to start a new feature branch (you should always do that for any new work) but it must start from and merge back to our 3.4/develop.

We cannot accept your contribution if it doesn't.

You shouldn't need to redo many of the changes for PHP5.5 that have already been done, since those things haven't changed again for PHP7 AFAIK?

@wwillisn
Copy link

wwillisn commented Dec 3, 2015

hello.

i am implement web pages and title solutions in kohana.
I can voluntee for task in kohana.
the scalable is wonderfull. i am contribute for implement for php7 system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants