[SC2031] false positive (from for PATH_W in ${PATH}; do)

[SwuduSusuwu]

For bugs

• Rule Id: SC2031
• My shellcheck version: https://github.com/SwuduSusuwu/SubStack/blob/trunk/.github/workflows/codacy.yml
• [ X ] The rule's wiki page does not already cover this (e.g. https://shellcheck.net/wiki/SC2031)
• [ X ] I tried on https://www.shellcheck.net/ and verified that this is still a problem on the latest commit

Here's a snippet or screenshot that shows the problem:

https://github.com/SwuduSusuwu/SubStack/blob/27721b2f195b598ac25fd052af0d27ca5ac0c48b/Macros.sh#L351-L402

Here's what shellcheck currently says:

PATH was modified in a subshell. That change might be lost.

Before this, it was In POSIX sh, local is undefined.

Here's what I wanted or expected to see:

All checks passed

[SwuduSusuwu]

It appears that this triggers whenever you follow the suggestion to replace local with subshells, and that the sole solution is to replace #!/bin/sh with

#!/bin/sh
#shellcheck disable=SC2031 #This triggers whenever you follow the suggestion to replace `local` with subshells (`$()`). 

[SwuduSusuwu]

SC2031 even triggers for [ -z "${PATH}" ], which does not have side effects (as this is just a conditional).