Use node test runner (#1845)

## Checklist
use `node --test` instead of `jest`
See: #1837 (comment)

- [X] I have ensured my pull request is not behind the main or master
branch of the original repository.
- [X] I have rebased all commits where necessary so that reviewing this
pull request can be done without having to merge it first.
- [X] I have written a commit message that passes commitlint linting.
- [X] I have ensured that my code changes pass linting tests.
- [X] I have ensured that my code changes pass unit tests.
- [X] I have described my pull request and the reasons for code changes
along with context if necessary.

Author: sirenkovladd

.github/workflows/node.js.yml

@@ -23,6 +23,6 @@ jobs:
         node-version: ${{ matrix.node-version }}
     - run: npm ci
     - run: npm run lint
-    - run: npm test -- --coverage --maxWorkers 2
+    - run: npm run test:coverage
     - run: npx codecov
       continue-on-error: true

__tests__/application/compose.js __tests__/application/compose.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const request = require('supertest')
 const assert = require('assert')
 const Koa = require('../..')

__tests__/application/context.js __tests__/application/context.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const request = require('supertest')
 const assert = require('assert')
 const Koa = require('../..')

__tests__/application/currentContext.js __tests__/application/currentContext.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const request = require('supertest')
 const assert = require('assert')
 const Koa = require('../..')

__tests__/application/index.js __tests__/application/index.test.js

@@ -1,12 +1,13 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const request = require('supertest')
 const assert = require('assert')
 const Koa = require('../..')
 
 describe('app', () => {
   // ignore test on Node.js v18
-  (/^v18\./.test(process.version) ? it.skip : it)('should handle socket errors', done => {
+  (/^v18\./.test(process.version) ? it.skip : it)('should handle socket errors', (t, done) => {
     const app = new Koa()
 
     app.use((ctx, next) => {
@@ -24,28 +25,6 @@ describe('app', () => {
       .end(() => {})
   })
 
-  it('should not .writeHead when !socket.writable', done => {
-    const app = new Koa()
-
-    app.use((ctx, next) => {
-      // set .writable to false
-      ctx.socket.writable = false
-      ctx.status = 204
-      // throw if .writeHead or .end is called
-      ctx.res.writeHead =
-      ctx.res.end = () => {
-        throw new Error('response sent')
-      }
-    })
-
-    // hackish, but the response should occur in a single tick
-    setImmediate(done)
-
-    request(app.callback())
-      .get('/')
-      .end(() => {})
-  })
-
   it('should set development env when NODE_ENV missing', () => {
     const NODE_ENV = process.env.NODE_ENV
     process.env.NODE_ENV = ''
@@ -80,7 +59,7 @@ describe('app', () => {
 
   it('should set compose from the constructor', () => {
     const compose = () => (ctx) => {}
-    const app = new Koa({ compose })
+    const app = new Koa.default({ compose }) // eslint-disable-line new-cap
     assert.strictEqual(app.compose, compose)
   })
 

__tests__/application/inspect.js __tests__/application/inspect.test.js

@@ -1,8 +1,11 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const assert = require('assert')
 const util = require('util')
 const Koa = require('../..')
+
+process.env.NODE_ENV = 'test'
 const app = new Koa()
 
 describe('app.inspect()', () => {

__tests__/application/onerror.js __tests__/application/onerror.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it, mock } = require('node:test')
 const assert = require('assert')
 const Koa = require('../..')
 
@@ -30,21 +31,21 @@ describe('app.onerror(err)', () => {
 
     err.status = 404
 
-    const spy = jest.spyOn(console, 'error')
+    const spy = mock.method(console, 'error', () => {})
     app.onerror(err)
-    expect(spy).not.toHaveBeenCalled()
-    spy.mockRestore()
+    assert.strictEqual(spy.mock.calls.length, 0)
+    spy.mock.restore()
   })
 
   it('should do nothing if .silent', () => {
     const app = new Koa()
     app.silent = true
     const err = new Error()
 
-    const spy = jest.spyOn(console, 'error')
+    const spy = mock.method(console, 'error', () => {})
     app.onerror(err)
-    expect(spy).not.toHaveBeenCalled()
-    spy.mockRestore()
+    assert.strictEqual(spy.mock.calls.length, 0)
+    spy.mock.restore()
   })
 
   it('should log the error to stderr', () => {
@@ -54,9 +55,9 @@ describe('app.onerror(err)', () => {
     const err = new Error()
     err.stack = 'Foo'
 
-    const spy = jest.spyOn(console, 'error')
+    const spy = mock.method(console, 'error', () => {})
     app.onerror(err)
-    expect(spy).toHaveBeenCalled()
-    spy.mockRestore()
+    assert.notStrictEqual(spy.mock.calls.length, 0)
+    spy.mock.restore()
   })
 })

__tests__/application/request.js __tests__/application/request.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const request = require('supertest')
 const assert = require('assert')
 const Koa = require('../..')

__tests__/application/respond.js __tests__/application/respond.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const request = require('supertest')
 const statuses = require('statuses')
 const assert = require('assert')
@@ -555,6 +556,20 @@ describe('app.respond', () => {
         .expect(200)
         .expect('content-type', 'application/octet-stream')
     })
+
+    it('should respond hello', async () => {
+      const app = new Koa()
+
+      app.use(async ctx => {
+        ctx.body = new Blob(['hello']).stream()
+      })
+
+      return request(app.callback())
+        .get('/')
+        .expect(200)
+        .expect('content-type', 'application/octet-stream')
+        .expect(Buffer.from('hello'))
+    })
   })
 
   describe('when .body is a Response', () => {
@@ -577,13 +592,14 @@ describe('app.respond', () => {
 
       app.use(ctx => {
         ctx.body = new Response(null, { status: 200, statusText: 'OK' })
+        console.log(ctx)
       })
 
       return request(app.callback())
-        .head('/')
+        .get('/')
         .expect(200)
         .expect('content-type', 'application/octet-stream')
-        .expect('content-length', '2')
+        .expect(Buffer.from([]))
     })
   })
 
@@ -662,7 +678,7 @@ describe('app.respond', () => {
         assert.deepStrictEqual(res.body, pkg)
       })
 
-    it('should handle errors', done => {
+    it('should handle errors', (t, done) => {
       const app = new Koa()
 
       app.use(ctx => {
@@ -690,7 +706,7 @@ describe('app.respond', () => {
         .expect(204)
     })
 
-    it('should handle all intermediate stream body errors', done => {
+    it('should handle all intermediate stream body errors', (t, done) => {
       const app = new Koa()
 
       app.use(ctx => {
@@ -742,7 +758,7 @@ describe('app.respond', () => {
   })
 
   describe('when an error occurs', () => {
-    it('should emit "error" on the app', done => {
+    it('should emit "error" on the app', (t, done) => {
       const app = new Koa()
 
       app.use(ctx => {

__tests__/application/response.js __tests__/application/response.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const request = require('supertest')
 const assert = require('assert')
 const Koa = require('../..')

__tests__/application/toJSON.js __tests__/application/toJSON.test.js

@@ -1,11 +1,12 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const assert = require('assert')
 const Koa = require('../..')
 
 describe('app.toJSON()', () => {
   it('should work', () => {
-    const app = new Koa()
+    const app = new Koa({ env: 'test' })
     const obj = app.toJSON()
 
     assert.deepStrictEqual({

__tests__/application/use.js __tests__/application/use.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const request = require('supertest')
 const assert = require('assert')
 const Koa = require('../..')

__tests__/context/assert.js __tests__/context/assert.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const context = require('../../test-helpers/context')
 const assert = require('assert')
 

__tests__/context/cookies.js __tests__/context/cookies.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const assert = require('assert')
 const request = require('supertest')
 const Koa = require('../..')

__tests__/context/inspect.js __tests__/context/inspect.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const prototype = require('../../lib/context')
 const assert = require('assert')
 const util = require('util')

__tests__/context/onerror.js __tests__/context/onerror.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const assert = require('assert')
 const request = require('supertest')
 const Koa = require('../..')
@@ -70,12 +71,13 @@ describe('ctx.onerror(err)', () => {
     assert.strictEqual(Object.prototype.hasOwnProperty.call(res.headers, 'x-csrf-token'), false)
   })
 
-  it('should ignore error after headerSent', done => {
+  it('should ignore error after headerSent', (t, done) => {
     const app = new Koa()
 
-    app.on('error', err => {
+    app.on('error', (err, { res }) => {
       assert.strictEqual(err.message, 'mock error')
       assert.strictEqual(err.headerSent, true)
+      res.end()
       done()
     })
 
@@ -252,7 +254,7 @@ describe('ctx.onerror(err)', () => {
       assert.strictEqual(removed, 2)
     })
 
-    it('should stringify error if it is an object', done => {
+    it('should stringify error if it is an object', (t, done) => {
       const app = new Koa()
 
       app.on('error', err => {

__tests__/context/state.js __tests__/context/state.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const request = require('supertest')
 const assert = require('assert')
 const Koa = require('../..')

__tests__/context/throw.js __tests__/context/throw.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const context = require('../../test-helpers/context')
 const assert = require('assert')
 

__tests__/context/toJSON.js __tests__/context/toJSON.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const assert = require('assert')
 const context = require('../../test-helpers/context')
 

__tests__/lib/search-params.js __tests__/lib/search-params.test.js

@@ -1,3 +1,4 @@
+const { describe, it } = require('node:test')
 const sp = require('../../lib/search-params')
 const assert = require('assert')
 

__tests__/load-with-esm.js __tests__/load-with-esm.test.js

@@ -1,3 +1,4 @@
+const { describe, it, beforeAll } = require('node:test')
 const assert = require('assert')
 
 let importESM = () => {}

__tests__/request/accept.js __tests__/request/accept.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const Accept = require('accepts')
 const assert = require('assert')
 const context = require('../../test-helpers/context')

__tests__/request/accepts.js __tests__/request/accepts.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const assert = require('assert')
 const context = require('../../test-helpers/context')
 

__tests__/request/acceptsCharsets.js __tests__/request/acceptsCharsets.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const assert = require('assert')
 const context = require('../../test-helpers/context')
 

__tests__/request/acceptsEncodings.js __tests__/request/acceptsEncodings.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const assert = require('assert')
 const context = require('../../test-helpers/context')
 

__tests__/request/acceptsLanguages.js __tests__/request/acceptsLanguages.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const assert = require('assert')
 const context = require('../../test-helpers/context')
 

__tests__/request/charset.js __tests__/request/charset.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const request = require('../../test-helpers/context').request
 const assert = require('assert')
 

__tests__/request/fresh.js __tests__/request/fresh.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const assert = require('assert')
 const context = require('../../test-helpers/context')
 

__tests__/request/get.js __tests__/request/get.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const assert = require('assert')
 const context = require('../../test-helpers/context')
 

__tests__/request/header.js __tests__/request/header.test.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const { describe, it } = require('node:test')
 const assert = require('assert')
 const request = require('../../test-helpers/context').request