Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computing #sum panics when aggregating over non-numeric values #632

Open
aannleax opened this issue Mar 20, 2025 · 0 comments
Open

Computing #sum panics when aggregating over non-numeric values #632

aannleax opened this issue Mar 20, 2025 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@aannleax
Copy link
Member

aannleax commented Mar 20, 2025

When using #sum over exclusively non-numeric values, nemo panics with the following error message:

thread 'main' panicked at nemo-physical/src/tabular/operations/aggregate.rs:308:25:
failed to compute aggregate result

This is because aggregates are currently implemented using the TrieScan interface, which does not allow for missing values.

Since the implementation of TrieScanAggregate is already complex enough, I would rather just rework how aggregates are computed using a technique similar to RowScans.

This issue was first discussed here: #629.

@aannleax aannleax added the bug Something isn't working label Mar 20, 2025
@aannleax aannleax added this to the Release 0.8.0 milestone Mar 20, 2025
@aannleax aannleax self-assigned this Mar 20, 2025
@aannleax aannleax added this to nemo Mar 20, 2025
@github-project-automation github-project-automation bot moved this to Todo in nemo Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant