Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to control the pod name prefix #56

Closed
grzn opened this issue Aug 29, 2024 · 2 comments · Fixed by #58
Closed

add option to control the pod name prefix #56

grzn opened this issue Aug 29, 2024 · 2 comments · Fixed by #58
Labels
enhancement New feature or request

Comments

@grzn
Copy link

grzn commented Aug 29, 2024

would be helpful to provide a name prefix for the pod from the commandline, it'll be helpful to identify which pod is used for what purpose when running multiple pods.

@knight42 knight42 added the enhancement New feature or request label Aug 31, 2024
@knight42
Copy link
Owner

I plan to add a flag, say --custom, so that users are able to specify the path to a JSON or YAML file containing a partial pod object to customize the relay agent pod.

Let's take your use case as an example, you can do something like this:

$ cat custom-pod.json
{"metadata": {"namePrefix": "your-name-prefix"} }

$ kubectl relay --custom custom-pod.json ...

@knight42
Copy link
Owner

knight42 commented Sep 3, 2024

@grzn Hi, with krelay 0.1.1, you could customize the krelay-server pod by the --patch/--patch-file flag. For instance:

$ kubectl relay --patch-file custom-pod.json ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants