Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeSelector and tolerations flags #47

Closed
mgss-cc opened this issue Jun 12, 2024 · 2 comments · Fixed by #58
Closed

Add nodeSelector and tolerations flags #47

mgss-cc opened this issue Jun 12, 2024 · 2 comments · Fixed by #58
Labels
enhancement New feature or request

Comments

@mgss-cc
Copy link

mgss-cc commented Jun 12, 2024

Hi,

It would be great if we are able to pass nodeSelector and tolerations as flags to the krelay command. Sometimes in multitenancy, we want pods to be deployed on certain nodes.

@knight42 knight42 added the enhancement New feature or request label Jul 11, 2024
@knight42
Copy link
Owner

I plan to add a flag, say --custom, so that users are able to specify the path to a JSON or YAML file containing a partial pod object to customize the relay agent pod.

Let's take your use case as an example, you can do something like this:

$ cat custom-pod.yaml
spec:
  tolerations:
    - ...
  nodeSelector:
    k: v

$ kubectl relay --custom custom-pod.yaml ...

@knight42
Copy link
Owner

knight42 commented Sep 3, 2024

@mgss-cc Hi, with krelay 0.1.1, you could customize the krelay-server pod by the --patch/--patch-file flag. For instance:

$ kubectl relay --patch-file custom-pod.yaml ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants