From cae3ab4070238f6bf9d43a68a13e42b9ded0370d Mon Sep 17 00:00:00 2001 From: Kaustubh pande Date: Tue, 1 Dec 2020 12:04:33 +0530 Subject: [PATCH] remove unnecessary help message --- CHANGELOG.adoc | 6 +++++- pkg/kn/commands/source/binding/describe.go | 2 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc index af46e3c68d..d457e54fba 100644 --- a/CHANGELOG.adoc +++ b/CHANGELOG.adoc @@ -17,6 +17,10 @@ |=== | | Description | PR +| 🐣 +| Removes unnecessary help message introduced for machine-readable outputs for command 'kn source binding describe' +| https://github.com/knative/client/pull/1158[#1158] + | 🐣 | Removes unnecessary help message introduced for machine-readable outputs for commands which does not have -o url flag | https://github.com/knative/client/pull/1152[#1152] @@ -33,7 +37,7 @@ | Add machine readable output (-o flag) to kn source binding describe | https://github.com/knative/client/pull/1148[#1148] -| 🐛 +| 🎁 | Add machine readable output (-o flag) to kn source apiserver describe | https://github.com/knative/client/pull/1146[#1146] diff --git a/pkg/kn/commands/source/binding/describe.go b/pkg/kn/commands/source/binding/describe.go index d34858072d..9d86d17cdc 100644 --- a/pkg/kn/commands/source/binding/describe.go +++ b/pkg/kn/commands/source/binding/describe.go @@ -18,7 +18,6 @@ import ( "errors" "fmt" "sort" - "strings" "github.com/spf13/cobra" "k8s.io/cli-runtime/pkg/genericclioptions" @@ -99,7 +98,6 @@ func NewBindingDescribeCommand(p *commands.KnParams) *cobra.Command { commands.AddNamespaceFlags(flags, false) flags.BoolP("verbose", "v", false, "More output.") machineReadablePrintFlags.AddFlags(command) - command.Flag("output").Usage = fmt.Sprintf("Output format. One of: %s.", strings.Join(machineReadablePrintFlags.AllowedFormats(), "|")) return command }