Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create integration tests for knative/serving with PipelineRun + TaskRun #227

Closed
bobcatfish opened this issue Nov 6, 2018 · 6 comments
Closed
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. meaty-juicy-coding-work This task is mostly about implementation!!! And docs and tests of course but that's a given

Comments

@bobcatfish
Copy link
Collaborator

Expected Behavior

In github.com/knative/serving, a Configuration (see overview) can contain a Build, which can be used to build the image which will be used in the Revision.

Thanks to duck typing (viewable by members of knative-dev@), it should be possible to use a PipelineRun or a TaskRun instead.

We should have e2e tests (maybe even confromance tests?) inside knative/serving which verify that Build can be swapped out for a TaskRun or a PipelineRun.

Actual Behavior

While this theoretically should work, we haven't tried it and there is nothing to ensure this keeps working over time.

Steps to Reproduce the Problem

The test should:

  1. Create a Configuration where the spec.build contains a TaskRun definition that uses a Task which builds the image which the Revision will use.
  2. Deploy the Configuration
  3. Verify that the image was built and deployed

Repeat the same for a PipelineRun.

Additional Info

Part of #147

@bobcatfish bobcatfish added this to the 0.0.1 Alpha release milestone Nov 6, 2018
@bobcatfish bobcatfish added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. meaty-juicy-coding-work This task is mostly about implementation!!! And docs and tests of course but that's a given labels Nov 6, 2018
@nader-ziada
Copy link
Member

nader-ziada commented Nov 20, 2018

@bobcatfish I think we need to have a release of pipeline first before we can a release.yaml in serving and try using it, wdyt?

@bobcatfish
Copy link
Collaborator Author

yeah that makes sense @pivotal-nader-ziada - the issue blocking this one then is #219

@bobcatfish
Copy link
Collaborator Author

bobcatfish commented Jan 10, 2019

After discussing with @pivotal-nader-ziada @shashwathi @imjasonh we think we can go forward for now by vendoring Pipelines at an arbitrary nightly release commit (maybe take a look at how serving currently vendors Build as well).

@vdemeester
Copy link
Member

/assign

@tejal29
Copy link
Contributor

tejal29 commented Jan 22, 2019

@vdemeester are you actively working on this one? I am looking to jump in on 0.4 release milestone issues.

@vdemeester
Copy link
Member

@tejal29 I started working on it yes, but digging into knative/serving, turns out knative/build is used there only for the API types, the test are using a fake building CRD (to be decoupled from the build component)

cc @mattmoor to tell me I'm wrong (or hopefully not 👼)

@bobcatfish bobcatfish added okr This is for some internal Google project tracking and removed okr This is for some internal Google project tracking labels Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. meaty-juicy-coding-work This task is mostly about implementation!!! And docs and tests of course but that's a given
Projects
None yet
Development

No branches or pull requests

4 participants