-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create integration tests for knative/serving
with PipelineRun + TaskRun
#227
Comments
@bobcatfish I think we need to have a release of |
yeah that makes sense @pivotal-nader-ziada - the issue blocking this one then is #219 |
After discussing with @pivotal-nader-ziada @shashwathi @imjasonh we think we can go forward for now by vendoring Pipelines at an arbitrary nightly release commit (maybe take a look at how serving currently vendors Build as well). |
/assign |
@vdemeester are you actively working on this one? I am looking to jump in on 0.4 release milestone issues. |
Expected Behavior
In github.com/knative/serving, a
Configuration
(see overview) can contain aBuild
, which can be used to build the image which will be used in theRevision
.Thanks to duck typing (viewable by members of knative-dev@), it should be possible to use a
PipelineRun
or aTaskRun
instead.We should have e2e tests (maybe even confromance tests?) inside
knative/serving
which verify thatBuild
can be swapped out for aTaskRun
or aPipelineRun
.Actual Behavior
While this theoretically should work, we haven't tried it and there is nothing to ensure this keeps working over time.
Steps to Reproduce the Problem
The test should:
Repeat the same for a
PipelineRun
.Additional Info
Part of #147
The text was updated successfully, but these errors were encountered: