Fixes target group replacement and extra logging #199
Conversation
| @@ -56,3 +56,12 @@ export const targetGroup = { | |||
| } | |||
| }, | |||
| } | |||
|
|
|||
| console.log( | |||
| ( | |||
There was a problem hiding this comment.
Just out of curiosity, what does the extra parenthesis do? (It's not a problem, I'm just wondering if there's something neat going on I don't know :) )
There was a problem hiding this comment.
🤦 I accidentally committed the line of code I was using to reproduce the issue. That was just a workaround to be able to invoke the fix function, which TypeScript complains about on its own because it might be undefined.
There was a problem hiding this comment.
Can use ! for cases where you know better than the compiler to assert that it isn't undefined.
| @@ -56,3 +56,12 @@ export const targetGroup = { | |||
| } | |||
| }, | |||
| } | |||
|
|
|||
| console.log( | |||
| ( | |||
There was a problem hiding this comment.
Can use ! for cases where you know better than the compiler to assert that it isn't undefined.
| @@ -1,6 +1,9 @@ | |||
| import Multimap = require('multimap') | |||
| import * as sha256 from 'simple-sha256' | |||
|
|
|||
| // Set debug = true to enable additional logging | |||
| let debug = false | |||
There was a problem hiding this comment.
nit: Would it be possible to make this a config value?
There was a problem hiding this comment.
as in pulumi config?
There was a problem hiding this comment.
There's also pulumi.log.[debug|info|etc], though I don't know exactly how they work. Maybe the verbose flag sets it?
DavidSeptimus-Klotho
force-pushed
the
patterns
branch
from
ad72174 to
759e06c
Compare
|
Fixes #196
Fixes the
fix()function for the broken rule by changing the replacement character from_to-and hides debug logging behind a flag.Standard checks