Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use klothoplatform/go-tree-sitter #168

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

gordon-klotho
Copy link
Contributor

@gordon-klotho gordon-klotho commented Jan 31, 2023

Switch to our fork of go-tree-sitter. Required fixes:

  • Removed the content/program bytes from .Content() (and upwards in function signatures/fields as needed)
  • New Python grammar changed how the with_item alias is represented (pkg/lang/python/queries/persist/aiofiles_open.scm)
  • Now that #match? works, NestJS test matches exactly the two controllers (pkg/lang/javascript/queries/expose/nestJs/module.scm + pkg/lang/javascript/nestjs_test.go).

Standard checks

  • Unit tests: Unit tests updated (not many changes needed in expectations, just updating to new APIs) and passing
  • Docs: Purely internal
  • Backwards compatibility: Purely internal - might break klotho-pro, will check after this gets merged.

@gordon-klotho gordon-klotho changed the title Internal/treesitter fork Update to use klothoplatform/go-tree-sitter Jan 31, 2023
@github-actions
Copy link

Package Line Rate Health
github.com/klothoplatform/klotho/pkg/analytics 2%
github.com/klothoplatform/klotho/pkg/annotation 23%
github.com/klothoplatform/klotho/pkg/cli 4%
github.com/klothoplatform/klotho/pkg/core 21%
github.com/klothoplatform/klotho/pkg/env_var 82%
github.com/klothoplatform/klotho/pkg/exec_unit 54%
github.com/klothoplatform/klotho/pkg/infra/kubernetes 59%
github.com/klothoplatform/klotho/pkg/infra/kubernetes/helm 39%
github.com/klothoplatform/klotho/pkg/input 63%
github.com/klothoplatform/klotho/pkg/lang 37%
github.com/klothoplatform/klotho/pkg/lang/dockerfile 0%
github.com/klothoplatform/klotho/pkg/lang/golang 19%
github.com/klothoplatform/klotho/pkg/lang/javascript 47%
github.com/klothoplatform/klotho/pkg/lang/python 60%
github.com/klothoplatform/klotho/pkg/lang/yaml 0%
github.com/klothoplatform/klotho/pkg/logging 7%
github.com/klothoplatform/klotho/pkg/multierr 95%
github.com/klothoplatform/klotho/pkg/provider/aws 59%
github.com/klothoplatform/klotho/pkg/runtime 75%
github.com/klothoplatform/klotho/pkg/static_unit 33%
github.com/klothoplatform/klotho/pkg/validation 73%
github.com/klothoplatform/klotho/pkg/yaml_util 79%
Summary 40% (3792 / 9445)

@gordon-klotho gordon-klotho merged commit 953a878 into main Feb 1, 2023
@gordon-klotho gordon-klotho deleted the internal/treesitter_fork branch February 1, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants