Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded bucket name from node emitter template #247

Closed
jhsinger-klotho opened this issue Feb 16, 2023 · 0 comments · Fixed by #287
Closed

Remove hardcoded bucket name from node emitter template #247

jhsinger-klotho opened this issue Feb 16, 2023 · 0 comments · Fixed by #287
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@jhsinger-klotho
Copy link
Contributor

Currently we pass the s3 payload bucket into the template and use that in the file

const payloadBucketPhysicalName = process.env.KLOTHO_S3_PREFIX + '{{.PayloadsBucketName}}';

https://github.com/klothoplatform/klotho-pro/issues/51 started the effort of moving this all to Environment variables so that we can dynamically generate these templates based on the iac created. This allows for proper sanitization and the resources to stay in sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants