Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit tests fail with v2.3.0 #67

Closed
kapsakcj opened this issue Jan 20, 2023 · 2 comments
Closed

unit tests fail with v2.3.0 #67

kapsakcj opened this issue Jan 20, 2023 · 2 comments

Comments

@kapsakcj
Copy link

Hi I recently upgraded to v2.3.0 and noticed that the included unit tests are now failing, where they previously ran successfully with v2.2.0

The consistent error seen throughout the output of python3 -m pytest have been similar to this, with varying sub-directories (the subdirs after test/):

----------------------------- Captured stderr call -----------------------------
BLAST options error: File test/test_res_mgrb_pmrb/data/CARD_v3.1.13.fasta does not exist

kleborate itself still runs successfully, so not a huge deal to fix, but thought I would let you all know!

Curtis

@rrwick
Copy link
Collaborator

rrwick commented Jan 23, 2023

Hi Curtis,

Thanks for letting us know! We recently updated the CARD database and forgot to change the filenames in the tests.

We've made the fix (renamed test/*/data/CARD_v3.0.8.fasta files to test/*/data/CARD_v3.1.13.fasta) and all tests are now passing. I'll made a new release (v2.3.1) with this fix.

Ryan

@rrwick rrwick closed this as completed Jan 23, 2023
@kapsakcj
Copy link
Author

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants