Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed(in:) doesn't call translatesAutoresizingMaskIntoConstraints = false #14

Open
Gargo opened this issue Nov 13, 2023 · 2 comments
Open
Assignees

Comments

@Gargo
Copy link

Gargo commented Nov 13, 2023

No description provided.

@kkiermasz kkiermasz self-assigned this Nov 13, 2023
@kkiermasz
Copy link
Owner

Hi @Gargo,

Thank you for submitting this.

Yes, it doesn't. This was by design since add(to:) and all related methods handle it.

It is worth exploring this topic. Could you please provide use cases in which you're missing that feature? As (I assume) there aren't many users of this library, it would be beneficial to understand how people use it.

@Gargo
Copy link
Author

Gargo commented Nov 20, 2023

@kkiermasz it is unclear why add and embed methods are declared nearby, look similar but the first one performs an essential method call and the second one doesn't.
It is also strange when you create a wrapper over the standard library with constraints and don't disable translatesAutoresizingMaskIntoConstraints which may break these constraints.

I often need to write similar things via different ways (and layout is one of them) so I often use random third-party libraries. Unfortunately there a lot of basic unresolved problems with your library so I've already switched to another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants