From 077ae16485f5049bbc7bd0f72dbea8ab84f16603 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Tue, 2 Oct 2018 19:12:32 +0200 Subject: [PATCH] crypto: set `DEFAULT_ENCODING` property to non-enumerable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Since it is a deprecated API, a deprecation warning is printed when loading crypto module from ESM. Making it non enumerable remove the deprecation warning and make the API non-available to named imports. PR-URL: https://github.com/nodejs/node/pull/23222 Fixes: https://github.com/nodejs/node/issues/23203 Reviewed-By: Colin Ihrig Reviewed-By: Guy Bedford Reviewed-By: James M Snell Reviewed-By: Anna Henningsen Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Refael Ackermann Reviewed-By: Tobias Nießen --- lib/crypto.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/crypto.js b/lib/crypto.js index 13987f9e03e230..2a41768414a740 100644 --- a/lib/crypto.js +++ b/lib/crypto.js @@ -230,7 +230,7 @@ Object.defineProperties(exports, { fipsForced ? setFipsForced : setFipsCrypto }, DEFAULT_ENCODING: { - enumerable: true, + enumerable: false, configurable: true, get: deprecate(getDefaultEncoding, 'crypto.DEFAULT_ENCODING is deprecated.', 'DEP0091'),