Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft of the new 404 error page #1178

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Draft of the new 404 error page #1178

wants to merge 1 commit into from

Conversation

veloman-yunkan
Copy link
Collaborator

@veloman-yunkan veloman-yunkan commented Feb 7, 2025 •
edited by kelson42
Loading

Fixes #710

@veloman-yunkan
Draft of the new 404 error page
2eb6eaf 
... so that its design can be tested in the browser (its responsiveness
is poor).

The page doesn't support translation.
@veloman-yunkan veloman-yunkan mentioned this pull request Feb 7, 2025
Open
@veloman-yunkan
Copy link
Collaborator Author

Please test having kiwix/kiwix-tools#710 (comment) in mind

kelson42
kelson42 reviewed Feb 9, 2025
View reviewed changes
Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, but I see a few differences in vertical spaces (in particular at the bottom of the picture) and font sizes (bigger here) with the mockup. But maybe this is only my Firefox!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelson42 kelson42 kelson42 left review comments

@rgaudin rgaudin Awaiting requested review from rgaudin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve look&feel of the Kiwix Server 404 page
2 participants
@veloman-yunkan @kelson42