Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA download menu gives access to dev and custom app folders #689

Closed
Popolechien opened this issue Feb 3, 2025 · 5 comments
Closed

PWA download menu gives access to dev and custom app folders #689

Popolechien opened this issue Feb 3, 2025 · 5 comments
Assignees
Labels
security Vulnerabilities or other issues affecting security user interface UI issues
Milestone

Comments

@Popolechien
Copy link
Member

Popolechien commented Feb 3, 2025

I'm on macOS, and I get to see folders at download.kiwix.org that I should not be seeing:

Image

archive and endless should not be there either.

@Jaifroid Jaifroid self-assigned this Feb 8, 2025
@Jaifroid Jaifroid added security Vulnerabilities or other issues affecting security user interface UI issues and removed enhancement labels Feb 8, 2025
@Jaifroid
Copy link
Member

Jaifroid commented Feb 8, 2025

@Popolechien Thanks for noticing that! Should I put in blocks for all of those?

@Jaifroid
Copy link
Member

Jaifroid commented Feb 8, 2025

Access to custom apps is needed for users who are using the smaller versions of MDWiki and who need to update their ZIM. It's currently empty of course because they were lost in the server switch, but I suppose it will start to be populated again when mwOffliner is restarted. I can hide the others, but is it OK to keep that one? The DWDS stuff was never there (which I understand is proprietary).

@Popolechien
Copy link
Member Author

LGTM

@Jaifroid Jaifroid transferred this issue from kiwix/kiwix-js Feb 8, 2025
@Jaifroid
Copy link
Member

Jaifroid commented Feb 8, 2025

This is now fixed in acdaa5f .

I'll increment the PWA so it's pushed to users after updating the changelog.

@Jaifroid Jaifroid closed this as completed Feb 8, 2025
@Jaifroid Jaifroid added this to the Release 3.6.0 milestone Feb 8, 2025
@Jaifroid
Copy link
Member

Jaifroid commented Feb 8, 2025

@Popolechien Done and published. Once the app has updated to v3.5.41, the mentioned directories (except custom_apps) will no longer be visible.

Image

It will offer the update next time you launch the app (shown at the top of Config), and then it will activate once the app is closed and re-opened. Until it shows this splash screen, the app has not yet updated. If you want to force it, use the Reset button at the top of Config.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Vulnerabilities or other issues affecting security user interface UI issues
Projects
None yet
Development

No branches or pull requests

2 participants