Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract message and passwordStrength out of form field inits #547

Open
PavelHolec opened this issue Apr 20, 2023 · 0 comments
Open

Extract message and passwordStrength out of form field inits #547

PavelHolec opened this issue Apr 20, 2023 · 0 comments
Assignees
Labels
accessibility Issues supporting accessibility features enhancement New feature or request

Comments

@PavelHolec
Copy link
Collaborator

For better flexibility and reducing form field-related component initializers, the message and password strength should be up to a call site to provide a specific view plus an accessibility identifier.

Now:

InputField(..., message:, passwordStrength: )

Proposed:

InputField(...) {
  PasswordStrength(...)
    .accessibility(.passwordStrengthId)
} message: {
  FieldMessage(...)
    .status(.warning)  // allows override of status
    .accessibility(.messageId)
}
.status(.critical)
@PavelHolec PavelHolec changed the title Extract message and passwordStrength out of fields Extract message and passwordStrength out of form field inits Apr 20, 2023
@PavelHolec PavelHolec added this to the 2023Q2 milestone Apr 20, 2023
@PavelHolec PavelHolec added enhancement New feature or request accessibility Issues supporting accessibility features labels Apr 20, 2023
@PavelHolec PavelHolec modified the milestones: 2023Q2, 2023Q3 Jun 19, 2023
@PavelHolec PavelHolec modified the milestones: 2023Q3, 2023Q4 Oct 16, 2023
@PavelHolec PavelHolec modified the milestones: 2023Q4, 2024Q1 Jan 5, 2024
@PavelHolec PavelHolec self-assigned this Feb 14, 2024
@PavelHolec PavelHolec removed this from the 2024Q1 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues supporting accessibility features enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant