Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing DialogProperties argument #115

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Add missing DialogProperties argument #115

merged 4 commits into from
Feb 19, 2024

Conversation

blipinsk
Copy link
Contributor

@blipinsk blipinsk commented Feb 3, 2024 •
edited
Loading

DialogProperties argument was missing from dialog extensions for NavGraphBuilder.
This PR fixes the problem (and updates the binary API file).

hrach
hrach reviewed Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@hrach hrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you please recreate the previous function without the argument to maintain binary compatibility? Make that function deprecated-hidden, please.

@blipinsk
Copy link
Contributor Author

blipinsk commented Feb 17, 2024 •
edited
Loading

sure thing @hrach! done ✅

  1. Do you have any preference regarding the body of those functions? should those be recreated as well? or would you prefer them to redirect to the new functions?
  2. Why don't I extract all deprecated-hidden functions to a separate file? Something like NavBuilderDeprecated.kt or NavBuilderLegacy.kt, to explicitly separate the "current" from the "outdated" api.

@blipinsk blipinsk requested a review from hrach February 17, 2024 12:28
@hrach
Copy link
Collaborator

hrach commented Feb 19, 2024

Thx, I think this will do :)

@hrach hrach enabled auto-merge February 19, 2024 08:17
@hrach hrach added the feature New feature or request label Feb 19, 2024
@hrach hrach changed the title Fix missing dialog properties Add missing DialogProperties argument Feb 19, 2024
auto-merge was automatically disabled February 19, 2024 10:18

Head branch was pushed to by a user without write access

@blipinsk
Copy link
Contributor Author

@hrach I pushed a fix for a lint issue, you'll need to enable the auto-merge again

@hrach hrach enabled auto-merge (squash) February 19, 2024 10:42
@hrach hrach merged commit 099da1e into kiwicom:main Feb 19, 2024
1 check passed
@blipinsk blipinsk deleted the fix-missing-dialog-properties branch February 20, 2024 11:17
@blipinsk
Copy link
Contributor Author

@hrach is there any timeline for the next release of the library (which will consist those ☝️ changes)?

@hrach hrach added the semver:minor PRs marker as minor will force next release to bump MINOR version label Feb 22, 2024
@hrach
Copy link
Collaborator

hrach commented Feb 22, 2024

What about now? :)

@blipinsk
Copy link
Contributor Author

Incredible @hrach 😍

@hrach
Copy link
Collaborator

hrach commented Feb 22, 2024

0.10.0 successfully deployed to maven central, wait a few minutes for propagation.
https://github.com/kiwicom/navigation-compose-typed/actions/runs/8004387187/job/21861670122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrach hrach hrach approved these changes

Assignees
No one assigned
Labels
feature New feature or request semver:minor PRs marker as minor will force next release to bump MINOR version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blipinsk @hrach