Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

does comrak allow spaces in footnote labels? cmark-gfm doesn't. #271

Closed
froh opened this issue Jan 11, 2023 · 2 comments
Closed

does comrak allow spaces in footnote labels? cmark-gfm doesn't. #271

froh opened this issue Jan 11, 2023 · 2 comments

Comments

@froh
Copy link

froh commented Jan 11, 2023

it looks like comrak allows space characters in footnote labels

cmark-gfm excludes space from footnote labels
@kivikakk kivikakk mentioned this issue Jan 25, 2023
Closed
@digitalmoksha digitalmoksha mentioned this issue Jun 1, 2023
Merged
@digitalmoksha
Copy link
Collaborator

@froh I think this is fixed now with the latest commits on main

one[^foo bar]
[^foo bar]: test

now yields

<p>one[^foo bar]
[^foo bar]: test</p>

for both cmark-gfm and comrak

@kivikakk
Copy link
Owner

Yep, that's right; thanks @digitalmoksha! And thanks @froh for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kivikakk @digitalmoksha @froh