Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure content type and filename information is appropriately passed to storage #201

Open
brianhelba opened this issue Jan 21, 2021 · 3 comments

Comments

@brianhelba
Copy link
Contributor

Ideally, this would result in MinIO / S3 automatically setting the Content-Type and Content-Disposition (the filename portion) headers for every download.

This probably involves setting the appropriate S3-Object metadata when the object is first created. The particular headers should be empirically verified. This may be a starting point for S3 headers.

The original information about the filename and content type should probably come from the client, but the server may also be able to infer content type (see #52).

This was originally reported in #197.

@dchiquito dchiquito self-assigned this Feb 18, 2021
@dchiquito
Copy link
Contributor

I can confirm that setting Content-Type and Content-Disposition will result in those values being set as HTTP headers on download. The AWS multipart upload docs indicate that those metadata fields can be specified as headers when initializing a multipart upload. The server can make informed guesses about the correct values and also accept values from the client.

@brianhelba
Copy link
Contributor Author

@dchiquito Just to clarify, you tested these headers on both AWS S3 and MinIO?

@dchiquito
Copy link
Contributor

Indeed I did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants