Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onchange and oninput events for the select tag #177

Closed
2 tasks done
gabor-s opened this issue Apr 3, 2024 · 10 comments · Fixed by #191
Closed
2 tasks done

Add onchange and oninput events for the select tag #177

gabor-s opened this issue Apr 3, 2024 · 10 comments · Fixed by #191
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gabor-s
Copy link

gabor-s commented Apr 3, 2024

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the bug has not already been reported

Versions

3.1.2

Description

There's no onchange and oninput event in the typings of HmtlSelectTag.

Steps to Reproduce

html/jsx.d.ts

Line 448 in 9ca8cdf

interface HtmlSelectTag extends HtmlTag {

Expected Behavior

No response

@gabor-s
Copy link
Author

gabor-s commented Apr 3, 2024

Maybe other event attributes are missing too.

@arthurfiorette
Copy link
Member

can you open a pr?

@gabor-s
Copy link
Author

gabor-s commented Apr 3, 2024

Sure. Do you know what event attributes are available on the HTML select tag?

@arthurfiorette
Copy link
Member

@gabor-s
Copy link
Author

gabor-s commented Apr 3, 2024

I know this documentation, but it only mentions that "Events fired by select: change, input", but I think onfocus also meaningful for select tags.

@gabor-s
Copy link
Author

gabor-s commented Apr 10, 2024

Why is that every JSX library creates its own typings for IntrinsicElements? Isn't it the same for everyone?

@arthurfiorette
Copy link
Member

I don't know... It sucks a lot to implement it manually... You're up to create a standard library for this? After we could create PRs to use it on many repos out there...

@arthurfiorette arthurfiorette self-assigned this Apr 11, 2024
@arthurfiorette arthurfiorette added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 11, 2024
@arthurfiorette arthurfiorette changed the title No onchange and oninput events for the select tag Add onchange and oninput events for the select tag Apr 11, 2024
@arthurfiorette
Copy link
Member

Anyone who wants to help with this issue, feel free to create a PR

@gabor-s
Copy link
Author

gabor-s commented Apr 11, 2024

Sorry, but I don't have the time right now.
I checked some other libraries. Preact uses its own types, but Solid for example uses types from dom-expression which also based on other libraries.

@JacopoPatroclo
Copy link

@arthurfiorette I can take this one. I'm not sure about the scope of this issue.
I think I should fix the missing types on the select HtmlSelectTag.
Then we should discuss how to improve this part of @kitajs/html deciding if we should use some open source typings for JSX or if we still use our definitions.

@JacopoPatroclo JacopoPatroclo self-assigned this Apr 17, 2024
@arthurfiorette arthurfiorette moved this to 📋 Backlog in Kita development Apr 19, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Kita development May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants