Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ":" in program_name of log stream name #207

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

SilentEroder
Copy link
Contributor

Problem

Windows contains ":" in program_name of log stream name.
For example, C:\

log stream name should not have ":" and "*". In regex, [^:*]
So, sys.argv[0] causes an error in Windows.

Solution

Remove all ":" in sys.argv[0]

program_name=sys.argv[0],  # before
program_name=sys.argv[0].replace(":", ""),  # after

Windows contains ":"
`C:\`
@kislyuk
Copy link
Owner

kislyuk commented Dec 30, 2024

Thanks. As we discussed in #208, Windows is not directly supported by this library. However, this change is sufficiently unobtrusive and has a clear enough purpose (the logger will fail without it) that I'm OK with accepting it.

@kislyuk kislyuk merged commit b6140d0 into kislyuk:main Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants