From d7a6566a141300f7bbdb49e98a02faf46dc0c68d Mon Sep 17 00:00:00 2001 From: Andrey Belym Date: Fri, 20 Jan 2017 18:56:50 +0300 Subject: [PATCH] Repair cursor (closes #1156) (#1160) * Revert overflow:hidden for ShadowUI root (closes #1156) * Fix cursor --- package.json | 2 +- src/client/ui/cursor/index.js | 7 ++----- src/client/ui/styles.less | 4 ++-- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/package.json b/package.json index 1a67e88bf96..a3a4e50af39 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "testcafe", "description": "Automated browser testing for the modern web development stack.", "license": "MIT", - "version": "0.12.0", + "version": "0.12.1", "author": { "name": "Developer Express Inc.", "url": "https://www.devexpress.com/" diff --git a/src/client/ui/cursor/index.js b/src/client/ui/cursor/index.js index 0917b07c849..5d3f7b237bd 100644 --- a/src/client/ui/cursor/index.js +++ b/src/client/ui/cursor/index.js @@ -10,7 +10,6 @@ var messageSandbox = hammerhead.eventSandbox.message; var styleUtils = testCafeCore.styleUtils; var positionUtils = testCafeCore.positionUtils; -var eventUtils = testCafeCore.eventUtils; const CURSOR_CLASS = 'cursor'; const TOUCH_CLASS = 'touch'; @@ -71,8 +70,6 @@ var CursorUI = { } shadowUI.getRoot().appendChild(this.cursorElement); - - eventUtils.bind(window, 'scroll', () => this.move(this.x, this.y)); }, isVisible () { @@ -101,8 +98,8 @@ var CursorUI = { this._createElement(); styleUtils.set(this.cursorElement, { - left: this.x + styleUtils.getScrollLeft(document) - this.pointerOffsetX + 'px', - top: this.y + styleUtils.getScrollTop(document) - this.pointerOffsetY + 'px' + left: this.x - this.pointerOffsetX + 'px', + top: this.y - this.pointerOffsetY + 'px' }); return Promise.resolve(); diff --git a/src/client/ui/styles.less b/src/client/ui/styles.less index 7d6cc47b37b..2f9f72a1ec0 100644 --- a/src/client/ui/styles.less +++ b/src/client/ui/styles.less @@ -16,7 +16,7 @@ left: 0px; top: 0px; margin: 0 !important; - overflow: hidden; + overflow: visible; .layout-default(); @@ -188,7 +188,7 @@ .cursor { .sprite-icon; - position: absolute; + .position-fixed(); left: 0; top: 0; width: 35px;