-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new behavior="translate-with-padding"
for KeyboardAvoidingView
#830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
behavior="translate"
for KeyboardAvoidingView
behavior="translate-with-padding"
for KeyboardAvoidingView
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
KeyboardAvoidingView 🧪
Anything related to KeyboardAvoidingView component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Added new
behavior="translate-with-padding"
forKeyboardAvoidingView
.💡 Motivation and Context
The new mode ideally fits for chat-like applications and has very good performance.
The implementation was mostly inspired by WindowInsetsAnimation sample app. However when I tried to replace
translateY
to0
and applypaddingBottom
which is equal to previoustranslateY
I had flashes on Android (mostly because of nature of Android - transform properties (e.g.,translateY
) only trigger a repaint (no reflow) and are applied immediately. Changes to layout properties like padding force the Android rendering system to recalculate layout (reflow), which can take an extra frame to resolve). So instead of switching those properties I decided to keeptranslateY
and addpaddingTop
(in the end of animation to resize the container).Since we change
paddingTop
only in the beginning or in the end of animation the transition is unbelievable smooth, because we trigger layout re-calculation only once (so in terms of complexity new approach isO(1)
vsO(n)
).Closes #719 (comment) software-mansion/react-native-reanimated#6854 #650 (comment)
🔢 Things to do
📢 Changelog
JS
"translate-with-padding"
behavior forKeyboardAvoidingView
useTranslateAnimation
hook;useTranslateAnimation
with"translate-with-padding"
;Docs
🤔 How Has This Been Tested?
Tested both paper and fabric on:
📸 Screenshots (if appropriate):
Paper
Screen.Recording.2025-02-23.at.18.44.49.mov
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-02-23.at.18.46.27.mp4
Fabric
Screen.Recording.2025-02-23.at.18.44.49.mov
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-02-23.at.18.53.48.mp4
📝 Checklist