Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 20.04 required for CI #39

Closed
cydanil opened this issue May 6, 2020 · 1 comment
Closed

Ubuntu 20.04 required for CI #39

cydanil opened this issue May 6, 2020 · 1 comment
Labels
CI good-first-issue If you want to get involved, these are nice low-barrier issues

Comments

@cydanil
Copy link
Collaborator

cydanil commented May 6, 2020

In the CI, the version of Ubuntu currently targeted is ubuntu-latest, which is 18.04 under the hood.

In this version of Ubuntu, the provided version of PyGObject does not have the key feature Pango.AttrList.get_iterator(), used by many parts of the application to where free-text is accepted (eg. entering the instructions of a recipe).

We can test this by doing the following:

In [1]: import gi

In [2]: gi.require_versions({'Gtk': '3.0', 'Pango': '1.0'})

In [3]: from gi.repository import Pango

In [4]: hasattr(Pango.AttrList,'get_iterator')
Out[4]: False

Ubuntu 20.04 has the latest version of libpango, and I confirmed that this test passes.

We are aware that Github is working on getting ubuntu-latest to be 20.04, but it's not there yet.

As such, most test won't pass, even if they're correct.

As we aim to target the libraries of Ubuntu 20.04 or equivalent, I suggest to wait it off until ubuntu-latest is 20.04, as we have plenty to do before anyway.

However, we are open to a contribution that would update the CI to make use of Ubuntu 20.04! 😄

Note that we have not tried tested this behaviour on Ubuntu 19.04.
Users of the latest Linux Mint (Tricia), will also run into this issue.

@cydanil cydanil added CI good-first-issue If you want to get involved, these are nice low-barrier issues labels May 6, 2020
@maweki
Copy link
Collaborator

maweki commented May 6, 2020

Just the say it here again: I think it is fine to target Ubuntu 20.04+. We can ignore distributions where python2 is still shipped out of the box, as gourmet is available and "supported" there. We're doing what we're doing because things have moved along so far.

@cydanil cydanil closed this as completed Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI good-first-issue If you want to get involved, these are nice low-barrier issues
Projects
None yet
Development

No branches or pull requests

2 participants