fix(data-loader): ignore unsupported fields from CSV export #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasshi-me
force-pushed
the
fix/csv-export-ignore-unsupported-fields
branch
from
172c6e7 to
ed20a89
Compare
tasshi-me
force-pushed
the
fix/csv-export-ignore-unsupported-fields
branch
from
5ea6fbf to
19f897e
Compare
tasshi-me
force-pushed
the
fix/csv-export-ignore-unsupported-fields
branch
from
19f897e to
01467f5
Compare
tasshi-me
commented
Jun 15, 2021
Comment on lines
-1
to
+236
| "unit": "", | ||
| "unitPosition": "BEFORE" | ||
| }, | ||
| "radioButton": { | ||
| "type": "RADIO_BUTTON", | ||
| "code": "radioButton", | ||
| "label": "radioButton", | ||
| "noLabel": false, | ||
| "required": true, | ||
| "options": { | ||
| "sample1": { | ||
| "label": "sample1", | ||
| "index": "0" | ||
| }, | ||
| "sample2": { | ||
| "label": "sample2", | ||
| "index": "1" | ||
| } | ||
| }, | ||
| "defaultValue": "sample1", | ||
| "align": "HORIZONTAL" | ||
| }, | ||
| "multiLineText": { | ||
| "type": "MULTI_LINE_TEXT", | ||
| "code": "multiLineText", | ||
| "label": "multiLineText", | ||
| "noLabel": false, | ||
| "required": false, | ||
| "defaultValue": "" | ||
| }, | ||
| "createdTime": { | ||
| "type": "CREATED_TIME", | ||
| "code": "createdTime", | ||
| "label": "createdTime", | ||
| "noLabel": false | ||
| }, | ||
| "checkBox": { | ||
| "type": "CHECK_BOX", | ||
| "code": "checkBox", | ||
| "label": "checkBox", | ||
| "noLabel": false, | ||
| "required": false, | ||
| "options": { | ||
| "\"sample1\"": { | ||
| "label": "\"sample1\"", | ||
| "index": "0" | ||
| }, | ||
| "\"sample2\"": { | ||
| "label": "\"sample2\"", | ||
| "index": "1" | ||
| } | ||
| }, | ||
| "defaultValue": [], | ||
| "align": "HORIZONTAL" | ||
| }, | ||
| "calc": { | ||
| "type": "CALC", | ||
| "code": "calc", | ||
| "label": "calc", | ||
| "noLabel": false, | ||
| "required": false, | ||
| "expression": "number + number", | ||
| "format": "NUMBER", | ||
| "displayScale": "", | ||
| "hideExpression": false, | ||
| "unit": "", | ||
| "unitPosition": "BEFORE" | ||
| }, | ||
| "multiSelect": { | ||
| "type": "MULTI_SELECT", | ||
| "code": "multiSelect", | ||
| "label": "multiSelect", | ||
| "noLabel": false, | ||
| "required": false, | ||
| "options": { | ||
| "sample1": { | ||
| "label": "sample1", | ||
| "index": "0" | ||
| }, | ||
| "tab\ttab": { | ||
| "label": "tab\ttab", | ||
| "index": "4" | ||
| }, | ||
| "\"sample2\"": { | ||
| "label": "\"sample2\"", | ||
| "index": "1" | ||
| }, | ||
| "sample4,sample5": { | ||
| "label": "sample4,sample5", | ||
| "index": "3" | ||
| }, | ||
| "\"sample3\"": { | ||
| "label": "\"sample3\"", | ||
| "index": "2" | ||
| } | ||
| }, | ||
| "defaultValue": [] | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
refactor: change line break (CRLF -> LF)
tasshi-me
requested review from
a team,
zaki-yama and
b4h0-c4t
and removed request for
a team
zaki-yama
approved these changes
Jun 29, 2021
tasshi-me
added a commit
that referenced
this pull request
Jul 4, 2022
* fix(data-loader): ignore unsupported fields from CSV export * test(data-loader): add tests of ignoring unsupported fields * test(data-loader): fix line break of fixture file CRLF -> LF * chore(test): fix descriptions Co-authored-by: Shingo Yamazaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Because exported CSV contains unsupported fields as blank value.
What
How to test
Checklist
yarn lintandyarn teston the root directory.