Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rest-api-client): add space.addThread() method #2846

Merged
merged 3 commits into from
Jul 9, 2024
Merged

feat(rest-api-client): add space.addThread() method #2846

merged 3 commits into from
Jul 9, 2024

Conversation

shabaraba
Copy link
Member

@shabaraba shabaraba commented Jun 27, 2024 •
edited
Loading

Why

Support addThread method to be able to add a tread to a space.

What

  • Add new method addThread
  • Add unit test
  • Add demo script

How to test

Check test spec

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@github-actions github-actions bot added the pkg: rest-api-client @kintone/rest-api-client label Jun 27, 2024
@shabaraba shabaraba marked this pull request as ready for review June 27, 2024 08:04
@shabaraba shabaraba requested a review from tasshi-me June 27, 2024 08:14
tasshi-me
tasshi-me requested changes Jun 28, 2024
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two change requests.
Please check it 👍

examples/rest-api-client-demo/src/space.ts Outdated Show resolved Hide resolved
packages/rest-api-client/docs/space.md Outdated Show resolved Hide resolved
@shabaraba shabaraba requested a review from tasshi-me June 28, 2024 02:48
tasshi-me
tasshi-me approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@tasshi-me tasshi-me requested a review from hisasami June 28, 2024 03:05
hisasami
hisasami approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@hisasami hisasami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tasshi-me tasshi-me merged commit e08575a into main Jul 9, 2024
17 checks passed
@tasshi-me tasshi-me deleted the feat/add-thread-method branch July 9, 2024 01:51
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hisasami hisasami hisasami approved these changes

@tasshi-me tasshi-me tasshi-me approved these changes

Assignees
No one assigned
Labels
pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shabaraba @tasshi-me @hisasami